Block: side inserter in Popover #19406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work reducing the markup! You raise a good question: what do we do about the plus button in an empty paragraph? Here's how it looks on desktop when not nested:
Here's the same, just inside a group:
As you note, the latter is also the case on mobile. Recently, the "recent blocks" shortcuts were removed, which make the remaining discrepancy all the more visible. In effort to keep things moving, and because we can always revisit, I would suggest it's okay to show the plus on the right, everywhere. And if something comes up, or if a better idea emerges from #18667, we can revisit! |
|
Related: #10519 |
ellatrix
force-pushed
the
try/side-inserter-popover
branch
from
7b59647
to
04f6345
Compare
|
Let's merge and explore more ideas. Another solution could be to show the inserter next to the caret on the right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the "side inserter" to the block controls popover.
It also consistently places it on the right side. Currently we place it on the right side on mobile and in nested context, but on the left on wide screens if the block is at the root. See #19045 (comment).
Either we should consistently place it on the right side, or we could consider moving it to the left side but within the block boundary. I picked the first option because we're already doing that on mobile and for nested paragraphs. If needed, we can explore the inside-left option separately.
How has this been tested?
Screenshots
Types of changes
Checklist: